[ 
https://issues.apache.org/jira/browse/CASSANDRA-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587776#comment-14587776
 ] 

Benedict commented on CASSANDRA-9499:
-------------------------------------

bq. For the writer there is no such ugliness, so we should at least implement 
this approach there: we build the long value we want, put it without moving the 
position, and then shift the position forwards by only the populated length.

It's worth pointing out this would be dangerous in the ByteOrder is flipped, so 
we should assert that the ByteOrder is LITTLE_ENDIAN _if we go with this 
approach_. Or we could remove the order() method for BufferedDataOutputPlus, 
and simply throw UnsupportedOperationException in writeVInt for 
SafeMemoryWriter (which is the only place that facility is used).

> Introduce writeVInt method to DataOutputStreamPlus
> --------------------------------------------------
>
>                 Key: CASSANDRA-9499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9499
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>            Priority: Minor
>             Fix For: 3.0 beta 1
>
>
> CASSANDRA-8099 really could do with a writeVInt method, for both fixing 
> CASSANDRA-9498 but also efficiently encoding timestamp/deletion deltas. It 
> should be possible to make an especially efficient implementation against 
> BufferedDataOutputStreamPlus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to