[ 
https://issues.apache.org/jira/browse/CASSANDRA-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599180#comment-14599180
 ] 

Branimir Lambov commented on CASSANDRA-9346:
--------------------------------------------

bq. Bracing style inconsistencies are throughout both CommitLogUpgradeTest and 
CommitLogUpgradeTestMaker,

Fixed and uploaded to branch.

bq. along with unused exceptions, vars, etc.

Saw one unused variable, but nothing else. I'm not seeing any warnings either. 
Could you point me to specific problems?

> Expand upgrade testing for commitlog changes
> --------------------------------------------
>
>                 Key: CASSANDRA-9346
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9346
>             Project: Cassandra
>          Issue Type: Test
>          Components: Tests
>            Reporter: Philip Thompson
>            Assignee: Branimir Lambov
>
> It seems that the current upgrade dtests always flush/drain a node before 
> upgrading it, meaning we have no coverage of reading the commitlog files from 
> a previous version.
> We should add (unless they exist somewhere I am not aware of ) a suite of 
> tests that specifically target upgrading with a significant amount of data 
> left in the commitlog files, that needs to be read by the upgraded node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to