[ 
https://issues.apache.org/jira/browse/CASSANDRA-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620191#comment-14620191
 ] 

Stefania commented on CASSANDRA-9448:
-------------------------------------

The change I proposed supports legacy and new names at the same time without 
any configuration switch. 

A configuration switch is certainly an easier alternative except we have 
hard-coded names scattered in NodeProbe.java and other places. Also, there is a 
substitution that is hidden away, if one day we need to use the word "Table" or 
"Partition" for new metrics, they would get converted to "ColumnFamily" or 
"Row" (I swapped the conversions of your patch because in the code we want to 
keep the new names, not the old ones). I suppose we could live with this 
provided it's documented.




> Metrics should use up to date nomenclature
> ------------------------------------------
>
>                 Key: CASSANDRA-9448
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9448
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Sam Tunnicliffe
>            Assignee: Stefania
>              Labels: docs-impacting, jmx
>             Fix For: 3.0 beta 1
>
>
> There are a number of exposed metrics that currently are named using the old 
> nomenclature of columnfamily and rows (meaning partitions).
> It would be good to audit all metrics and update any names to match what they 
> actually represent; we should probably do that in a single sweep to avoid a 
> confusing mixture of old and new terminology. 
> As we'd need to do this in a major release, I've initially set the fixver for 
> 3.0 beta1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to