[ 
https://issues.apache.org/jira/browse/CASSANDRA-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631112#comment-14631112
 ] 

Sylvain Lebresne commented on CASSANDRA-9472:
---------------------------------------------

I'll note that unless I'm forgetting something, re-introducing this is not 
terribly complex (especially post-CASSANDRA-9705). CASSANDRA-8099 hasn't 
touched the off-heap memtable machinery much, so I think all we need is to 
implement the {{NativeAllocator.rowBuilder}} method (referencing CASSANDRA-9705 
patch here). Which in turns mainly mean writting a {{NativeRow}} implementation 
that is the counterpart of our previous {{NativeCell}} implementations (and we 
can likely salvage some of the code of said {{NativeCell}}). This thus require 
to come up with a reasonable serialization format for offheap rows, but that's 
hardly rocket science.

Note that I'm just talking here of doing what this ticket is actually about, 
which is to re-introduce off-heap memtables in a way that is as close as 
possible from what we had pre-CASSANDRA-8099. And I don't think we should wait 
on Java 9 or anything to do that. Of course we will improve on all this in the 
future, but let's please leave that to some future ticket. 

> Reintroduce off heap memtables
> ------------------------------
>
>                 Key: CASSANDRA-9472
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9472
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>             Fix For: 3.x
>
>
> CASSANDRA-8099 removes off heap memtables. We should reintroduce them ASAP.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to