Author: gdusbabek Date: Mon Dec 27 22:19:01 2010 New Revision: 1053207 URL: http://svn.apache.org/viewvc?rev=1053207&view=rev Log: merge from 0.7
Modified: cassandra/trunk/ (props changed) cassandra/trunk/CHANGES.txt cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java (props changed) cassandra/trunk/src/java/org/apache/cassandra/service/AbstractCassandraDaemon.java cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java cassandra/trunk/test/unit/org/apache/cassandra/tools/SSTableExportTest.java Propchange: cassandra/trunk/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 27 22:19:01 2010 @@ -1,5 +1,5 @@ /cassandra/branches/cassandra-0.6:922689-1051640,1051662 -/cassandra/branches/cassandra-0.7:1026517-1052542 +/cassandra/branches/cassandra-0.7:1026517-1053205 /incubator/cassandra/branches/cassandra-0.3:774578-796573 /incubator/cassandra/branches/cassandra-0.4:810145-834239,834349-834350 /incubator/cassandra/branches/cassandra-0.5:888872-915439 Modified: cassandra/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/trunk/CHANGES.txt?rev=1053207&r1=1053206&r2=1053207&view=diff ============================================================================== --- cassandra/trunk/CHANGES.txt (original) +++ cassandra/trunk/CHANGES.txt Mon Dec 27 22:19:01 2010 @@ -14,6 +14,7 @@ * avoid polluting page cache with commitlog or sstable writes and seq scan operations (CASSANDRA-1470) * add OpenBitSet to support larger bloom filters (CASSANDRA-1555) + * handle URL-specified log4j regression (CASSANDRA-1907) 0.7.0-rc3 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 27 22:19:01 2010 @@ -1,5 +1,5 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:922689-1051640,1051662 -/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1026517-1052542 +/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1026517-1053205 /incubator/cassandra/branches/cassandra-0.3/interface/gen-java/org/apache/cassandra/service/Cassandra.java:774578-796573 /incubator/cassandra/branches/cassandra-0.4/interface/gen-java/org/apache/cassandra/service/Cassandra.java:810145-834239,834349-834350 /incubator/cassandra/branches/cassandra-0.5/interface/gen-java/org/apache/cassandra/service/Cassandra.java:888872-903502 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 27 22:19:01 2010 @@ -1,5 +1,5 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:922689-1051640,1051662 -/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1026517-1052542 +/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1026517-1053205 /incubator/cassandra/branches/cassandra-0.3/interface/gen-java/org/apache/cassandra/service/column_t.java:774578-792198 /incubator/cassandra/branches/cassandra-0.4/interface/gen-java/org/apache/cassandra/service/Column.java:810145-834239,834349-834350 /incubator/cassandra/branches/cassandra-0.5/interface/gen-java/org/apache/cassandra/service/Column.java:888872-903502 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 27 22:19:01 2010 @@ -1,5 +1,5 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java:922689-1051640,1051662 -/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java:1026517-1052542 +/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java:1026517-1053205 /incubator/cassandra/branches/cassandra-0.3/interface/gen-java/org/apache/cassandra/service/InvalidRequestException.java:774578-796573 /incubator/cassandra/branches/cassandra-0.4/interface/gen-java/org/apache/cassandra/service/InvalidRequestException.java:810145-834239,834349-834350 /incubator/cassandra/branches/cassandra-0.5/interface/gen-java/org/apache/cassandra/service/InvalidRequestException.java:888872-903502 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 27 22:19:01 2010 @@ -1,5 +1,5 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java:922689-1051640,1051662 -/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java:1026517-1052542 +/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java:1026517-1053205 /incubator/cassandra/branches/cassandra-0.3/interface/gen-java/org/apache/cassandra/service/NotFoundException.java:774578-796573 /incubator/cassandra/branches/cassandra-0.4/interface/gen-java/org/apache/cassandra/service/NotFoundException.java:810145-834239,834349-834350 /incubator/cassandra/branches/cassandra-0.5/interface/gen-java/org/apache/cassandra/service/NotFoundException.java:888872-903502 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 27 22:19:01 2010 @@ -1,5 +1,5 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java:922689-1051640,1051662 -/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java:1026517-1052542 +/cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java:1026517-1053205 /incubator/cassandra/branches/cassandra-0.3/interface/gen-java/org/apache/cassandra/service/superColumn_t.java:774578-792198 /incubator/cassandra/branches/cassandra-0.4/interface/gen-java/org/apache/cassandra/service/SuperColumn.java:810145-834239,834349-834350 /incubator/cassandra/branches/cassandra-0.5/interface/gen-java/org/apache/cassandra/service/SuperColumn.java:888872-903502 Modified: cassandra/trunk/src/java/org/apache/cassandra/service/AbstractCassandraDaemon.java URL: http://svn.apache.org/viewvc/cassandra/trunk/src/java/org/apache/cassandra/service/AbstractCassandraDaemon.java?rev=1053207&r1=1053206&r2=1053207&view=diff ============================================================================== --- cassandra/trunk/src/java/org/apache/cassandra/service/AbstractCassandraDaemon.java (original) +++ cassandra/trunk/src/java/org/apache/cassandra/service/AbstractCassandraDaemon.java Mon Dec 27 22:19:01 2010 @@ -21,6 +21,8 @@ package org.apache.cassandra.service; import java.io.File; import java.io.IOException; import java.net.InetAddress; +import java.net.MalformedURLException; +import java.net.URL; import java.util.UUID; import java.util.concurrent.RejectedExecutionException; import java.util.concurrent.SynchronousQueue; @@ -59,7 +61,20 @@ public abstract class AbstractCassandraD static { String config = System.getProperty("log4j.configuration", "log4j-server.properties"); - PropertyConfigurator.configureAndWatch(ClassLoader.getSystemResource(config).getFile(), 10000); + URL configLocation = null; + try + { + // try loading from a physical location first. + configLocation = new URL(config); + } + catch (MalformedURLException ex) + { + // load from the classpath. + configLocation = AbstractCassandraDaemon.class.getClassLoader().getResource(config); + if (configLocation == null) + throw new RuntimeException("Couldn't figure out log4j configuration."); + } + PropertyConfigurator.configureAndWatch(configLocation.getFile(), 10000); org.apache.log4j.Logger.getLogger(AbstractCassandraDaemon.class).info("Logging initialized"); } Modified: cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java URL: http://svn.apache.org/viewvc/cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java?rev=1053207&r1=1053206&r2=1053207&view=diff ============================================================================== --- cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java (original) +++ cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java Mon Dec 27 22:19:01 2010 @@ -19,7 +19,6 @@ package org.apache.cassandra.utils; import java.io.*; -import java.lang.reflect.Constructor; import java.lang.reflect.Field; import java.lang.reflect.InvocationTargetException; import java.math.BigInteger; @@ -36,6 +35,7 @@ import java.util.concurrent.atomic.Atomi import java.util.concurrent.atomic.AtomicLong; import com.google.common.base.Charsets; +import com.google.common.base.Joiner; import org.apache.commons.collections.iterators.CollatingIterator; import org.apache.commons.lang.ArrayUtils; import org.slf4j.Logger; @@ -146,7 +146,7 @@ public class FBUtilities remainder = distance.testBit(0); midpoint = distance.shiftRight(1).add(left).mod(max); } - return new Pair(midpoint, remainder); + return new Pair<BigInteger, Boolean>(midpoint, remainder); } /** @@ -634,9 +634,7 @@ public class FBUtilities public static String decodeToUTF8(ByteBuffer bytes) throws CharacterCodingException { - bytes = bytes.duplicate(); - String decoded = Charsets.UTF_8.newDecoder().decode(bytes).toString(); - return decoded; + return Charsets.UTF_8.newDecoder().decode(bytes.duplicate()).toString(); } /** @@ -736,7 +734,7 @@ public class FBUtilities { if (!partitionerClassName.contains(".")) partitionerClassName = "org.apache.cassandra.dht." + partitionerClassName; - return FBUtilities.<IPartitioner>construct(partitionerClassName, "partitioner"); + return FBUtilities.construct(partitionerClassName, "partitioner"); } public static AbstractType getComparator(String compareWith) throws ConfigurationException @@ -789,11 +787,10 @@ public class FBUtilities */ public static <T> T construct(String classname, String readable) throws ConfigurationException { - Class<T> cls = FBUtilities.<T>classForName(classname, readable); + Class<T> cls = FBUtilities.classForName(classname, readable); try { - Constructor ctor = cls.getConstructor(); - return (T)ctor.newInstance(); + return cls.getConstructor().newInstance(); } catch (NoSuchMethodException e) { @@ -822,20 +819,8 @@ public class FBUtilities public static String toString(Map<?,?> map) { - // wtf, why isn't something like this in guava or commons collections? - StringBuilder sb = new StringBuilder("{"); - for (Map.Entry<?,?> entry : map.entrySet()) - { - sb.append(toString(entry.getKey())).append(": ").append(toString(entry.getValue())).append(", "); - } - sb.append("}"); - return sb.toString(); - } - - /** slow! */ - private static Object toString(Object o) - { - return o.getClass().isArray() ? Arrays.toString((Object[]) o) : o.toString(); + Joiner.MapJoiner joiner = Joiner.on(",").withKeyValueSeparator(":"); + return joiner.join(map); } /** Modified: cassandra/trunk/test/unit/org/apache/cassandra/tools/SSTableExportTest.java URL: http://svn.apache.org/viewvc/cassandra/trunk/test/unit/org/apache/cassandra/tools/SSTableExportTest.java?rev=1053207&r1=1053206&r2=1053207&view=diff ============================================================================== --- cassandra/trunk/test/unit/org/apache/cassandra/tools/SSTableExportTest.java (original) +++ cassandra/trunk/test/unit/org/apache/cassandra/tools/SSTableExportTest.java Mon Dec 27 22:19:01 2010 @@ -97,7 +97,7 @@ public class SSTableExportTest extends S ColumnFamily cfamily = ColumnFamily.create("Keyspace1", "Standard1"); SSTableWriter writer = new SSTableWriter(tempSS.getPath(), 2); - int nowInSec = (int)(System.currentTimeMillis() / 1000); + int nowInSec = (int)(System.currentTimeMillis() / 1000) + 42; //live for 42 seconds // Add rowA cfamily.addColumn(new QueryPath("Standard1", null, ByteBufferUtil.bytes("colA")), ByteBufferUtil.bytes("valA"), 1); cfamily.addColumn(null, new ExpiringColumn(ByteBufferUtil.bytes("colExp"), ByteBufferUtil.bytes("valExp"), 1, 42, nowInSec));