[ https://issues.apache.org/jira/browse/CASSANDRA-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644262#comment-14644262 ]
Branimir Lambov commented on CASSANDRA-9888: -------------------------------------------- +1 Comments are not quite right [here|https://github.com/apache/cassandra/commit/7635cfa9c58693560a89e32233d65fd98cc22a85#diff-4b911b7d0959c6219175e2349968f3cdR245] and [here|https://github.com/apache/cassandra/commit/7635cfa9c58693560a89e32233d65fd98cc22a85#diff-4b911b7d0959c6219175e2349968f3cdR864]. > BTreeBackedRow and ComplexColumnData > ------------------------------------ > > Key: CASSANDRA-9888 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9888 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Benedict > Assignee: Benedict > Fix For: 3.0 beta 1 > > > I found ArrayBackedRow a little hard to follow, especially around building, > so I've converted it to BTreeBackedRow, along with ComplexColumnData. Both > now rely on BTree.Builder, which introduces a little extra functionality to > permit these classes to be implemented more declaratively. Transformations of > these classes are also now uniform and more declarative, also depending on > some new functionality in BTree that permits applying a > transformation/filtration to an existing btree (this could be optimised at a > later date, but should suffice for now). > The result is IMO both clearer and should scale more gracefully to larger > numbers of columns and complex cells. > This hasn't taken all of the possible improvements of the back of this change > to their natural conclusion, as we are somewhat time pressed and I would > prefer to get the ball rolling with this first round. -- This message was sent by Atlassian JIRA (v6.3.4#6332)