[ 
https://issues.apache.org/jira/browse/CASSANDRA-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659129#comment-14659129
 ] 

Ariel Weisberg commented on CASSANDRA-9265:
-------------------------------------------

Anyone object to backporting this change to 2.2?

I thought cache versions shared the database version, but they don't. They are 
versioned independently. Which is a little scary if the persisted cache uses 
serialization that changes between database versions. It depends on 
RowIndexEntry and CachedPartition serializations and whatever those depend on.

> Add checksum to saved cache files
> ---------------------------------
>
>                 Key: CASSANDRA-9265
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9265
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ariel Weisberg
>             Fix For: 2.2.1, 3.0 beta 1
>
>         Attachments: 
> 0001-Add-checksum-to-saved-cache-files-CASSANDRA-9265.patch, 
> 0002-trunk-CASSANDRA-9265.patch
>
>
> Saved caches are not covered by a checksum. We should at least emit a 
> checksum. My suggestion is a large checksum of the whole file (convenient 
> offline validation), and then smaller per record checksums after each record 
> is written (possibly a subset of the incrementally maintained larger 
> checksum).
> I wouldn't go for anything fancy to try to recover from corruption since it 
> is just a saved cache. If corruption is detected while reading I would just 
> have it bail out. I would rather have less code to review and test in this 
> instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to