[ 
https://issues.apache.org/jira/browse/CASSANDRA-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661425#comment-14661425
 ] 

Daniel Chia commented on CASSANDRA-10003:
-----------------------------------------

I think there's a combination of two things that causes the weirdness:

1) There's actually an issue in calculating timestamp, where we overflow the 
(int) nowInSeconds in converting it into a timestamp. Due to bad (good?) luck, 
up until really recently, this caused timestamp to overflow to a negative 
number, which made non of the range tombstones actually shadow any of the data 
in rows.

2) I think this test really meant to test the iterator without the 
`removeShadowedData` flag set to true, but that's what the test does.

> RowAndDeletionMergeIteratorTest is failing on 3.0 and trunk
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-10003
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10003
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Yuki Morishita
>            Priority: Blocker
>             Fix For: 3.0.x
>
>
> RowAndDeletionMergeIteratorTest is falling with the followings:
> {code}
>     [junit] Testcase: 
> testWithAtMostRangeTombstone(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
>        FAILED
>     [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
>     [junit] junit.framework.AssertionFailedError: expected:<ROW> but 
> was:<RANGE_TOMBSTONE_MARKER>
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithAtMostRangeTombstone(RowAndDeletionMergeIteratorTest.java:134)
>     [junit]
>     [junit]
>     [junit] Testcase: 
> testWithGreaterThanRangeTombstone(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
>   FAILED
>     [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
>     [junit] junit.framework.AssertionFailedError: expected:<ROW> but 
> was:<RANGE_TOMBSTONE_MARKER>
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithGreaterThanRangeTombstone(RowAndDeletionMergeIteratorTest.java:179)
>     [junit]
>     [junit]
>     [junit] Testcase: 
> testWithAtMostAndGreaterThanRangeTombstone(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
>  FAILED
>     [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
>     [junit] junit.framework.AssertionFailedError: expected:<ROW> but 
> was:<RANGE_TOMBSTONE_MARKER>
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithAtMostAndGreaterThanRangeTombstone(RowAndDeletionMergeIteratorTest.java:207)
>     [junit]
>     [junit]
>     [junit] Testcase: 
> testWithIncludingEndExcludingStartMarker(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
>    FAILED
>     [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
>     [junit] junit.framework.AssertionFailedError: expected:<ROW> but 
> was:<RANGE_TOMBSTONE_MARKER>
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithIncludingEndExcludingStartMarker(RowAndDeletionMergeIteratorTest.java:257)
>     [junit]
>     [junit]
>     [junit] Testcase: 
> testWithExcludingEndIncludingStartMarker(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
>    FAILED
>     [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
>     [junit] junit.framework.AssertionFailedError: expected:<ROW> but 
> was:<RANGE_TOMBSTONE_MARKER>
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
>     [junit]     at 
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithExcludingEndIncludingStartMarker(RowAndDeletionMergeIteratorTest.java:297)
> {code}
> cassci started to show the failure recently, but I can go back as far as 
> {{2457599427d361314dce4833abeb5cd4915d0b06}} to see the failure on local.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to