[
https://issues.apache.org/jira/browse/CASSANDRA-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697187#comment-14697187
]
Ariel Weisberg commented on CASSANDRA-9500:
-------------------------------------------
Permit misaligned flushes is just as inaccurate since now it is incorrectly
named for the constraint that you can't write direct to a channel.
Which code path are you looking for coverage of?
The only uncovered paths are close(), applyToChannel, order(), the little
endian branch of writeSlow(), and writeExcessSlow that you just introduced.
writeExcessSlow has indirect coverage that works well from
CompressedSequentailWriterTest. I'll add a test to BDOSPTest just in case.
I don't see the case for varying buffer size. What is that supposed to cover?
> SequentialWriter should extend BufferedDataOutputStreamPlus
> -----------------------------------------------------------
>
> Key: CASSANDRA-9500
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9500
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Benedict
> Assignee: Ariel Weisberg
> Priority: Minor
>
> SequentialWriter is the last piece left not implementing
> DataOutputStreamPlus. It should not be too tricky to extend it, and it should
> result in improved write throughput. Further, it will permit it to exploit
> the more efficient implementation of writeVInt being delivered in
> CASSANDRA-9499
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
