[ 
https://issues.apache.org/jira/browse/CASSANDRA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698916#comment-14698916
 ] 

Stefania commented on CASSANDRA-10086:
--------------------------------------

Thanks for the patch Paul, it's definitely +1. 

Only one trivial nit: {{<clearCommand>}} should perhaps follow existing 
commands. I know we managed to break the order already, but existing commands 
are mostly ordered so we may want to move clearCommand after exitCommand, or it 
can be done during commit.

I tested it manually on Linux and it works. I could not test it on Windows or 
Mac.

As for automated tests, have a look at _cqlsh_tests/cqlsh_tests.py_ in the 
[distributed tests|https://github.com/riptano/cassandra-dtest]. Normally we 
check a cqlsh command by looking at its output. In this case it is a bit tricky 
though as there is no output and the lack of output doesn't necessarily mean 
the screen was cleared. Still, we could perhaps just add a test to show that 
there is no error, to at least exercise the new code path.

If it is too time consuming to install the distributed tests I can write a test 
for you as it won't take me long.

[~jbellis]: this is only for trunk or previous versions too?

> Add a "CLEAR" cqlsh command to clear the console
> ------------------------------------------------
>
>                 Key: CASSANDRA-10086
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10086
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Paul O'Fallon
>            Priority: Trivial
>              Labels: cqlsh
>         Attachments: 10086.txt
>
>
> It would be very helpful to have a "CLEAR" command to clear the cqlsh 
> console.  I learned (after researching a patch for this) that lowercase 
> CTRL+L will clear the screen, but having a discrete command would make that 
> more obvious.  To match the expectations of Windows users, an alias to "CLS" 
> would be nice as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to