[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14700967#comment-14700967 ]
Stefania commented on CASSANDRA-7066: ------------------------------------- Thanks for spotting this, I hadn't noticed it. See if this [amended commit|https://github.com/stef1927/cassandra/commit/f5d6f310d2f3136728d4773b996d824f588039a2] is better. Instead of passing an argument I exported the charset from {{FileUtils}} since it shouldn't really change. Probably best to wait for CI: http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-7066-b-dtest/ http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-7066-b-testall/ > Simplify (and unify) cleanup of compaction leftovers > ---------------------------------------------------- > > Key: CASSANDRA-7066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7066 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Benedict > Assignee: Stefania > Priority: Minor > Labels: benedict-to-commit, compaction > Fix For: 3.0 alpha 1 > > Attachments: 7066.txt > > > Currently we manage a list of in-progress compactions in a system table, > which we use to cleanup incomplete compactions when we're done. The problem > with this is that 1) it's a bit clunky (and leaves us in positions where we > can unnecessarily cleanup completed files, or conversely not cleanup files > that have been superceded); and 2) it's only used for a regular compaction - > no other compaction types are guarded in the same way, so can result in > duplication if we fail before deleting the replacements. > I'd like to see each sstable store in its metadata its direct ancestors, and > on startup we simply delete any sstables that occur in the union of all > ancestor sets. This way as soon as we finish writing we're capable of > cleaning up any leftovers, so we never get duplication. It's also much easier > to reason about. -- This message was sent by Atlassian JIRA (v6.3.4#6332)