[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708431#comment-14708431 ]
Robert Stupp commented on CASSANDRA-9738: ----------------------------------------- Branch is ready for another review round. It's rebased against current 3.0 and trunk. Changes are: * updated to ohc 0.4.2 (to get rid of {{ByteBuffer.order()}} calls and the try-finally-clauses) * no more duplicate serialization effort in {{serializedSize()}} + {{serialize()}} - uses a thread-local serialization buffer. Can be further improved with CASSANDRA-9929. * added/moved string serialization methods to {{ByteBufferUtil}}, which has distinct code paths for 7-bit ASCII and strings with wider chars > Migrate key-cache to be fully off-heap > -------------------------------------- > > Key: CASSANDRA-9738 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9738 > Project: Cassandra > Issue Type: Sub-task > Reporter: Robert Stupp > Assignee: Robert Stupp > Fix For: 3.0 beta 2 > > > Key cache still uses a concurrent map on-heap. This could go to off-heap and > feels doable now after CASSANDRA-8099. > Evaluation should be done in advance based on a POC to prove that pure > off-heap counter cache buys a performance and/or gc-pressure improvement. > In theory, elimination of on-heap management of the map should buy us some > benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)