[
https://issues.apache.org/jira/browse/CASSANDRA-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711914#comment-14711914
]
Benedict commented on CASSANDRA-9625:
-------------------------------------
Looks like a legitimate bug. Since 0c65759ef4cb91bbca60881c9e3aae39ce9ddc2f
we've asserted the Memory hasn't been freed when checking its size, but that's
not strictly necessary. Here we have concurrent access, so there's no way to
guarantee safely reading its size, without perhaps ensuring all {{Memory}}
instances are refcounted, and taking a reference before reading it.
Personally I would be OK with either removing the assertion or upgrading all of
these memory instances to {{SafeMemory}}, since we don't have loads of them
(and any produced through compaction are already {{SafeMemory}}, so eventually
all on the host probably will be anyway).
[~jbellis] introduced the original assertion, so perhaps he has an opinion.
> GraphiteReporter not reporting
> ------------------------------
>
> Key: CASSANDRA-9625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9625
> Project: Cassandra
> Issue Type: Bug
> Environment: Debian Jessie, 7u79-2.5.5-1~deb8u1, Cassandra 2.1.3
> Reporter: Eric Evans
> Assignee: T Jake Luciani
> Attachments: metrics.yaml, thread-dump.log
>
>
> When upgrading from 2.1.3 to 2.1.6, the Graphite metrics reporter stops
> working. The usual startup is logged, and one batch of samples is sent, but
> the reporting interval comes and goes, and no other samples are ever sent.
> The logs are free from errors.
> Frustratingly, metrics reporting works in our smaller (staging) environment
> on 2.1.6; We are able to reproduce this on all 6 of production nodes, but not
> on a 3 node (otherwise identical) staging cluster (maybe it takes a certain
> level of concurrency?).
> Attached is a thread dump, and our metrics.yaml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
