[ 
https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731817#comment-14731817
 ] 

Robert Stupp commented on CASSANDRA-9738:
-----------------------------------------

Had to rebuild the branch as rebase w/ resolving conflicts would have been like 
opening a can of worms.
Unit tests look good and cstar shows the known numbers.

The old state is still there for reference 
[here|https://github.com/snazy/cassandra/tree/9738-key-cache-ohc-before-10136-notest]
 and [here 
(squashed)|https://github.com/snazy/cassandra/tree/9738-key-cache-ohc-before-10136-squashed-notest].

Optimizations in the "new" version are not that sophisticated as in the "old" 
one for backward compatibility as implemented by CASSANDRA-10136.


> Migrate key-cache to be fully off-heap
> --------------------------------------
>
>                 Key: CASSANDRA-9738
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9738
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>             Fix For: 3.0.0 rc1
>
>
> Key cache still uses a concurrent map on-heap. This could go to off-heap and 
> feels doable now after CASSANDRA-8099.
> Evaluation should be done in advance based on a POC to prove that pure 
> off-heap counter cache buys a performance and/or gc-pressure improvement.
> In theory, elimination of on-heap management of the map should buy us some 
> benefit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to