[ https://issues.apache.org/jira/browse/CASSANDRA-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978446#action_12978446 ]
Jonathan Ellis commented on CASSANDRA-1714: ------------------------------------------- Sorry; it really makes it difficult when reading e.g. svn annotate to see what was actually relevant to the zero-copy read change. Please re-submit with the other changes backed out. You're welcome to create a ticket for the refactorings. (FWIW, a git-based workflow like the one I described in http://spyced.blogspot.com/2009/06/patch-oriented-development-made-sane.html makes it much easier to keep these kinds of changes separated out.) > zero-copy reads > --------------- > > Key: CASSANDRA-1714 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1714 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Jonathan Ellis > Assignee: Pavel Yaskevich > Fix For: 0.7.1 > > Attachments: CASSANDRA-1714-v2.patch, CASSANDRA-1714.patch, > zerocopy.txt > > Original Estimate: 32h > Remaining Estimate: 32h > > Since we are already using mmap'd ByteBuffers in MappedFileDataInput we > should be able to do zero-copy reads (via buffer.slice()), which would give > us better performance than CASSANDRA-1651 without having to worry about > buffer management. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.