[ 
https://issues.apache.org/jira/browse/CASSANDRA-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740423#comment-14740423
 ] 

Stefania commented on CASSANDRA-10238:
--------------------------------------

I was able to fix the dtest on 2.1 with the [patch 
attached|https://github.com/stef1927/cassandra/commits/10238-2.1]. The problem 
is that when the snitch reloads its configuration it does not update the 
topology in the token metadata. Nor do we do this when we receive an updated 
rack or dc over Gossip.

I still need to add some unit tests for {{TokenMetadata.Topology}}, since I 
modified it somewhat.  

Do we also need more dtests? Things like:
* Any other snitches that can update their configuration
* Any other snitch configuration parameters can be updated other than the rack
* Multiple dcs
* Adding racks

Once the review of the 2.1 patch is completed I will up-merge to the 2.2+ 
branches. Do we want this for 2.0 as well?

CI for 2.1:

http://cassci.datastax.com/job/stef1927-10238-2.1-testall
http://cassci.datastax.com/job/stef1927-10238-2.1-dtest

> Consolidating racks violates the RF contract
> --------------------------------------------
>
>                 Key: CASSANDRA-10238
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10238
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Brandon Williams
>            Assignee: Stefania
>            Priority: Critical
>
> I have only tested this on 2.0 so far, but I suspect it will affect multiple 
> versions.
> Repro:
> * create a datacenter with rf>1
> * create more than one rack in this datacenter
> * consolidate these racks into 1
> * getendpoints will reveal the RF in practice is 1, even though other tools 
> will report the original RF that was set
> Restarting Cassandra will resolve this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to