[ 
https://issues.apache.org/jira/browse/CASSANDRA-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933330#comment-14933330
 ] 

Björn Hegerfors commented on CASSANDRA-10276:
---------------------------------------------

I have one comment on this patch. If for some reason the STCS won't find 
something to compact even though bucket.size() > maxThreshold (sounds unlikely 
with default STCS options), then just skipping that window might render that 
window uncompacted for all eternity. IMO, rather than trying the next window, 
as in the latest commit, why not just return the maxThreshold smallest SSTables 
from the bucket?

> With DTCS, do STCS in windows if more than max_threshold sstables
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-10276
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10276
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.x, 2.1.x, 2.2.x
>
>
> To avoid constant recompaction of files in big ( > max threshold) DTCS 
> windows, we should do STCS of those files.
> Patch here: https://github.com/krummas/cassandra/commits/marcuse/dtcs_stcs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to