[ 
https://issues.apache.org/jira/browse/CASSANDRA-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944216#comment-14944216
 ] 

Yuki Morishita commented on CASSANDRA-10341:
--------------------------------------------

Thanks for the patch.
Overall it's good.
I think we can improve constructing bounds to invalidate by sorting SSTables by 
its token bound(see {{SSTableReader.sstableComparator}}), eliminating overlaps.
Also, I like to call Bounds as bounds instead of {{inclusiveRanges}}.

> Streaming does not guarantee cache invalidation
> -----------------------------------------------
>
>                 Key: CASSANDRA-10341
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10341
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Paulo Motta
>             Fix For: 2.1.x, 2.2.x, 3.0.x
>
>
> Looking at the code, we attempt to invalidate the row cache for any rows we 
> receive via streaming, however we invalidate them immediately, before the new 
> data is available. So, if it is requested (which is likely if it is "hot") in 
> the interval, it will be re-cached and not invalidated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to