[
https://issues.apache.org/jira/browse/CASSANDRA-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960295#comment-14960295
]
Benedict commented on CASSANDRA-10529:
--------------------------------------
No, I'll commit this alongside the other small patches we have queued.
> Channel.size() is costly, mutually exclusive, and on the critical path
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-10529
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10529
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Benedict
> Assignee: Stefania
> Fix For: 3.0.0 rc2
>
>
> [~stefania_alborghetti] mentioned this already on another ticket, but I have
> lost track of exactly where. While benchmarking it became apparent this was a
> noticeable bottleneck for small in-memory workloads with few files,
> especially with RF=1. We should probably fix this soon, since it is trivial
> to do so, and the call is only to impose an assertion that our requested
> length is less than the file size. It isn't possible to safely memoize a
> value anywhere we can guarantee to be able to safely refer to it without some
> refactoring, so I suggest simply removing the assertion for now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
