[
https://issues.apache.org/jira/browse/CASSANDRA-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972510#comment-14972510
]
Robert Stupp commented on CASSANDRA-8755:
-----------------------------------------
The changes to use StringUtils are fine IMO.
WRT to {{String.replace}} I'd prefer to use a precompiled {{Pattern}} instance
for those usages that are on a "hot path" - these are {{ColumnIdentifier}},
{{CommitLogArchiver}}, {{AbstractCompositeType}}, {{TupleType}},
{{PropertyFileSnitch}}, {{CassandraIndex}}, {{Snapshot}}.
(IntelliJ can warn on uses of {{String.replace}} and offers an automated
refactoring on it.)
I don't expect a measurable improvement by this patch, but it's worth to be
included.
> Replace trivial uses of String.replace/replaceAll/split with StringUtils
> methods
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-8755
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8755
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jaroslav Kamenik
> Priority: Trivial
> Labels: lhf
> Attachments: trunk-8755.patch, trunk-8755.txt
>
>
> There are places in the code where those regex based methods are used with
> plain, not regexp, strings, so StringUtils alternatives should be faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
