[ https://issues.apache.org/jira/browse/CASSANDRA-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-10605: ------------------------------------------ Reviewer: Aleksey Yeschenko > MessagingService: COUNTER_MUTATION verb is associated with MUTATION stage > ------------------------------------------------------------------------- > > Key: CASSANDRA-10605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10605 > Project: Cassandra > Issue Type: Bug > Reporter: Anubhav Kale > Fix For: 2.1.x > > Attachments: trunk-10605.patch > > > In MessagingService.java, I see that the verb COUNTER_MUTATION is associated > with COUNTER_MUTATION stage first, and later with MUTATION stage. We should > remove appropriate entry. > I marked this as Major because I think the stage assignment is wrong. > What should this be assigned to ? > public static final EnumMap<MessagingService.Verb, Stage> verbStages = new > EnumMap<MessagingService.Verb, Stage>(MessagingService.Verb.class) > {{ > put(Verb.MUTATION, Stage.MUTATION); > ****put(Verb.COUNTER_MUTATION, Stage.COUNTER_MUTATION);***** > put(Verb.READ_REPAIR, Stage.MUTATION); > put(Verb.HINT, Stage.MUTATION); > put(Verb.TRUNCATE, Stage.MUTATION); > put(Verb.PAXOS_PREPARE, Stage.MUTATION); > put(Verb.PAXOS_PROPOSE, Stage.MUTATION); > put(Verb.PAXOS_COMMIT, Stage.MUTATION); > put(Verb.BATCH_STORE, Stage.MUTATION); > put(Verb.BATCH_REMOVE, Stage.MUTATION); > put(Verb.READ, Stage.READ); > put(Verb.RANGE_SLICE, Stage.READ); > put(Verb.INDEX_SCAN, Stage.READ); > put(Verb.PAGED_RANGE, Stage.READ); > put(Verb.REQUEST_RESPONSE, Stage.REQUEST_RESPONSE); > put(Verb.INTERNAL_RESPONSE, Stage.INTERNAL_RESPONSE); > put(Verb.STREAM_REPLY, Stage.MISC); // actually handled by > FileStreamTask and streamExecutors > put(Verb.STREAM_REQUEST, Stage.MISC); > put(Verb.REPLICATION_FINISHED, Stage.MISC); > put(Verb.SNAPSHOT, Stage.MISC); > put(Verb.TREE_REQUEST, Stage.ANTI_ENTROPY); > put(Verb.TREE_RESPONSE, Stage.ANTI_ENTROPY); > put(Verb.STREAMING_REPAIR_REQUEST, Stage.ANTI_ENTROPY); > put(Verb.STREAMING_REPAIR_RESPONSE, Stage.ANTI_ENTROPY); > put(Verb.REPAIR_MESSAGE, Stage.ANTI_ENTROPY); > put(Verb.GOSSIP_DIGEST_ACK, Stage.GOSSIP); > put(Verb.GOSSIP_DIGEST_ACK2, Stage.GOSSIP); > put(Verb.GOSSIP_DIGEST_SYN, Stage.GOSSIP); > put(Verb.GOSSIP_SHUTDOWN, Stage.GOSSIP); > put(Verb.DEFINITIONS_UPDATE, Stage.MIGRATION); > put(Verb.SCHEMA_CHECK, Stage.MIGRATION); > put(Verb.MIGRATION_REQUEST, Stage.MIGRATION); > put(Verb.INDEX_SCAN, Stage.READ); > put(Verb.REPLICATION_FINISHED, Stage.MISC); > *****put(Verb.COUNTER_MUTATION, Stage.MUTATION);****** > put(Verb.SNAPSHOT, Stage.MISC); > put(Verb.ECHO, Stage.GOSSIP); > put(Verb.UNUSED_1, Stage.INTERNAL_RESPONSE); > put(Verb.UNUSED_2, Stage.INTERNAL_RESPONSE); > put(Verb.UNUSED_3, Stage.INTERNAL_RESPONSE); > }}; -- This message was sent by Atlassian JIRA (v6.3.4#6332)