[ https://issues.apache.org/jira/browse/CASSANDRA-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986327#comment-14986327 ]
Andre Turgeon commented on CASSANDRA-10358: ------------------------------------------- As for the bug mentioned in #2 above. It appears that the code change for CASSANDRA-7360 introduced the bug. I'm not sure how to keep the benefits of CASSANDRA-7360 and fix the bug. [~slebresne], you worked on CASSANDRA-7360, do you have any suggestions? Should I create a new Jira to address the bug separately? > Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter > ------------------------------------------------------------------------- > > Key: CASSANDRA-10358 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10358 > Project: Cassandra > Issue Type: Improvement > Reporter: Andre Turgeon > Priority: Minor > Attachments: SSTableWriterCreationStrategy.patch, patch.txt > > > I've created a patch for your consideration. > This change to CQLSSTableWriter allows for a custom > AbstractSSTableSimpleWriter to be specified. > I needed this for a bulkload process I wrote. I believe the change would be > beneficial for other people as well. > Below are the reasons I needed a custom implementation of > AbstractSSTableSimpleWriter: > 1) The available implementations of AbstractSSTableSimpleWriter do not > provide a way to specify the filename (or rather revision) of the sstable. I > needed to control the name because my bulkload process write sstables in > parallel (on multiple machines) and I wish to avoid name collisions. > 2) I discovered a problem with SSTableSimpleUnsortedWriter where it creates > invalid level-compaction-style sstables; It allows a partition to span 2 > sstables which violates the "no overlap of token ranges" constraint of level > compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)