[ https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987732#comment-14987732 ]
Aleksey Yeschenko commented on CASSANDRA-10365: ----------------------------------------------- Pushed a commit addressing all of review feedback. All incorporated with some exceptions: bq. Why expose/use CQLTypeParser.parseRaw() instead of CQLTypeParse.parse() (In SchemaKeyspace.fetchTypes). That's the only place we use it/need it. To fetch types themselves and resolve dependencies. bq. CQL3Type.UserDefined.toString() doesn't quote stuffs properly (if the udt name is a quoted name). SchemaKeyspace.bbToString() has the same problem. {{SchemaKeyspace.bbToString()}} does not have the same problem. We don't quote table, keyspace, type, function, etc. names, and shouldn't be quoting field names in {{schema.types}} either, for consistency reasons. Quoting those is the job of the driver. > Store types by their CQL names in schema tables instead of fully-qualified > internal class names > ----------------------------------------------------------------------------------------------- > > Key: CASSANDRA-10365 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10365 > Project: Cassandra > Issue Type: Improvement > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Labels: client-impacting > Fix For: 3.0.0 > > > Consider saving CQL types names for column, UDF/UDA arguments and return > types, and UDT components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)