[
https://issues.apache.org/jira/browse/CASSANDRA-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988380#comment-14988380
]
Tyler Hobbs commented on CASSANDRA-10614:
-----------------------------------------
After reproducing this, I discovered a couple of problems, one of which was not
related to CASSANDRA-9664. The error was occurring when the streamed sstables
were processed through the view. Some partitions had a mixture of complete
rows and partial rows (due to only having an {{UPDATE}} on non-selected columns
and no {{INSERT}}). The complete rows allowed the partitions to pass the
filtering checks and the checks for live/non-empty rows in
{{updateAppliesToView()}}. However, later down the line, we weren't correctly
handling individual non-live rows or rows that didn't match the filter when
generating view mutations. This could result in empty rows being inserted into
the view (the error discovered here) or rows that didn't match the filters
being inserted into the view.
These two issues were easy to reproduce with {{BATCH}} statements, so I've
extended two unit tests to reproduce the issue.
[~tjake] can you review the [latest
commit|https://github.com/thobbs/cassandra/commit/9938b0a0e88938202c45de6b22c32f82b871f042]
that I've pushed?
> AssertionError while flushing memtables
> ---------------------------------------
>
> Key: CASSANDRA-10614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10614
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
> Reporter: Tyler Hobbs
> Assignee: Tyler Hobbs
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: debug.log, system.log
>
>
> While running mvbench against a single local node, I noticed this stacktrace
> showing up multiple times in the logs:
> {noformat}
> ERROR 16:40:01 Exception in thread Thread[MemtableFlushWriter:1,5,main]
> java.lang.AssertionError: null
> at org.apache.cassandra.db.rows.Rows.collectStats(Rows.java:70)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.format.big.BigTableWriter$StatsCollector.applyToRow(BigTableWriter.java:197)
> ~[main/:na]
> at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:116)
> ~[main/:na]
> at
> org.apache.cassandra.db.transform.UnfilteredRows.isEmpty(UnfilteredRows.java:38)
> ~[main/:na]
> at
> org.apache.cassandra.db.ColumnIndex.writeAndBuildIndex(ColumnIndex.java:49)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.format.big.BigTableWriter.append(BigTableWriter.java:149)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter.append(SimpleSSTableMultiWriter.java:45)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.SSTableTxnWriter.append(SSTableTxnWriter.java:52)
> ~[main/:na]
> at
> org.apache.cassandra.db.Memtable$FlushRunnable.writeSortedContents(Memtable.java:389)
> ~[main/:na]
> at
> org.apache.cassandra.db.Memtable$FlushRunnable.runMayThrow(Memtable.java:352)
> ~[main/:na]
> at
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> ~[main/:na]
> at
> com.google.common.util.concurrent.MoreExecutors$DirectExecutorService.execute(MoreExecutors.java:299)
> ~[guava-18.0.jar:na]
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1037)
> ~[main/:na]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> ~[na:1.8.0_45]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> ~[na:1.8.0_45]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_45]
> {noformat}
> To reproduce, run mvbench with the regular schema and the following arguments:
> {noformat}
> mvn exec:java -Dexec.args="--num-users 100000 --num-songs 1000000
> --num-artists 10000 -n 500000 --endpoint 127.0.0.1"
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
