Repository: cassandra Updated Branches: refs/heads/trunk 8f189d110 -> 943294ba2
Disable value skipping as that breaks read-repair currently patch by slebresne; reviewed by beobal for CASSANDRA-10655 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/92533603 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/92533603 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/92533603 Branch: refs/heads/trunk Commit: 925336031ac24b0bb0cb5d1daf5c91bf71462649 Parents: cc4d759 Author: Sylvain Lebresne <sylv...@datastax.com> Authored: Thu Nov 5 15:52:32 2015 +0100 Committer: Sylvain Lebresne <sylv...@datastax.com> Committed: Fri Nov 6 10:53:55 2015 +0100 ---------------------------------------------------------------------- CHANGES.txt | 1 + src/java/org/apache/cassandra/db/filter/ColumnFilter.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cassandra/blob/92533603/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 433bc85..98c98ab 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0 + * Remove value skipping as it breaks read-repair (CASSANDRA-10655) * Fix bootstrapping with MVs (CASSANDRA-10621) * Make sure EACH_QUORUM reads are using NTS (CASSANDRA-10584) * Fix MV replica filtering for non-NetworkTopologyStrategy (CASSANDRA-10634) http://git-wip-us.apache.org/repos/asf/cassandra/blob/92533603/src/java/org/apache/cassandra/db/filter/ColumnFilter.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/cassandra/db/filter/ColumnFilter.java b/src/java/org/apache/cassandra/db/filter/ColumnFilter.java index 62329ab..05eade5 100644 --- a/src/java/org/apache/cassandra/db/filter/ColumnFilter.java +++ b/src/java/org/apache/cassandra/db/filter/ColumnFilter.java @@ -123,7 +123,8 @@ public class ColumnFilter */ public boolean canSkipValue(ColumnDefinition column) { - return isFetchAll && selection != null && !selection.contains(column); + // We don't use that currently, see #10655 for more details. + return false; } /**
