[ https://issues.apache.org/jira/browse/CASSANDRA-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010395#comment-15010395 ]
Stefania commented on CASSANDRA-9043: ------------------------------------- Thanks for the patch. I checked the 2.1 version so far and it looks reasonable. Are you able to add a test for this code using [cassandra dtest|https://github.com/riptano/cassandra-dtest]? cqlsh copy tests are located in _cqlsh_tests/cqlsh_copy_tests.py_. Some nits: * There are some pep8 errors: {code} /home/stefi/git/cstar/cassandra/bin/cqlsh:1786:58: E226 missing whitespace around arithmetic operator /home/stefi/git/cstar/cassandra/bin/cqlsh:1788:57: E226 missing whitespace around arithmetic operator /home/stefi/git/cstar/cassandra/bin/cqlsh:1788:61: E226 missing whitespace around arithmetic operator /home/stefi/git/cstar/cassandra/bin/cqlsh:1789:63: E231 missing whitespace after ',' {code} * I would prefer string formatting to several '+' operators at lines 1786 and 1788 if anything for compatibility with line 1789. * Should {{where_class}} be {{where_clause}}? > Improve COPY command to work with Counter columns > ------------------------------------------------- > > Key: CASSANDRA-9043 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9043 > Project: Cassandra > Issue Type: Improvement > Reporter: Sebastian Estevez > Assignee: ZhaoYang > Priority: Minor > Labels: lhf > Fix For: 3.x > > Attachments: CASSANDRA-9043(2.1.8).patch, CASSANDRA-9043-trunk.patch > > > Noticed today that the copy command doesn't work with counter column tables. > This makes sense given that we need to use UPDATE instead of INSERT with > counters. > Given that we're making improvements in the COPY command in 3.0 with > CASSANDRA-7405, can we also tweak it to work with counters? -- This message was sent by Atlassian JIRA (v6.3.4#6332)