[ https://issues.apache.org/jira/browse/CASSANDRA-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028883#comment-15028883 ]
Branimir Lambov commented on CASSANDRA-9991: -------------------------------------------- Not that cheap, walking the tree will always be expensive to some extent. It may be better to go with something closer to the original version then, where remove finds the leaf and passes indices to {{removeFromLeaf}} and {{swap}} (which isn't much more code as {{isLeaf}} can disappear), but I will leave that choice to you. The current code LGTM as well. [{{BTree.swap}}|https://github.com/apache/cassandra/compare/trunk...blambov:haaawk/9991#diff-4b911b7d0959c6219175e2349968f3cdR330] should use the naming of {{replaceInSitu}} and contain the same warning. [Testall|http://cassci.datastax.com/job/blambov-haaawk-9991-testall/] looks same as trunk, [dtest|http://cassci.datastax.com/job/blambov-haaawk-9991-dtest/] is still running. > Implement efficient btree removal > --------------------------------- > > Key: CASSANDRA-9991 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9991 > Project: Cassandra > Issue Type: Sub-task > Reporter: Benedict > Labels: patch > Fix For: 3.x > > Attachments: trunk-9991-v3.txt, trunk-9991.txt, trunk-9991.txt-v2 > > > Currently removal is implemented as a reconstruction by filtering and > iterator over the original btree. This could be much more efficient, editing > just the necessary nodes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)