[ https://issues.apache.org/jira/browse/CASSANDRA-9428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064411#comment-15064411 ]
Joshua McKenzie commented on CASSANDRA-9428: -------------------------------------------- Feedback: * In {{CompressedChecksummedDataInput.reBufferStandard:L65}}, consider {{ICompressor.initialCompressedBufferLength}} rather than 5% allocation overhead. * {{HintsWriter.bufferWrites}}: I'm not crazy about us having a volatile increment in the critical path that's only used in a testing context. * In {{HintsCompressionTest.multiFlushAndDeserializeTest}}, bitshifting on init of {{bufferSize}} is unnecessary. * Would prefer {{HintsCompressionTest}} to exercise all available compressor types as a matter of general hygiene. Nits: * extra space in yaml before new param * extra space before closing brace in HintsWriter.create() * unused imports in HintsCompressionTest * some extra whitespace (doubled) in {{HintsCompressionTest.multiFlushAndDeserializeTest}} I'm fine with both the caveats you mention above. Looking good so far! > Implement hints compression > --------------------------- > > Key: CASSANDRA-9428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9428 > Project: Cassandra > Issue Type: Sub-task > Components: Coordination > Reporter: Aleksey Yeschenko > Assignee: Blake Eggleston > Fix For: 3.0.x > > > CASSANDRA-6230 is being implemented with compression in mind, but it's not > going to be implemented by the original ticket. > Adding it on top should be relatively straight-forward, and important, since > there are several users in the wild that use compression interface for > encryption purposes. DSE is one of them (but isn't the only one). Losing > encryption capabilities would be a regression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)