[
https://issues.apache.org/jira/browse/CASSANDRA-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069736#comment-15069736
]
Paulo Motta edited comment on CASSANDRA-9303 at 12/23/15 3:21 PM:
------------------------------------------------------------------
Looks good now. Tested locally and all options look good. Dtests are also
passing. Only minor nit is to use {{os.linesep}} instead of {{'\n'}} on
{{_printmsg(msg, eol='\n')}}.
bq. It doesn't work because stdin is actually set to the file specified with
the -f option. Since this is not an issue with COPY but with the way -f is
implemented, I would prefer deferring to another ticket if this functionality
is required.
+1
bq. I've also rebased on the 2.1 branch (since CASSANDRA-9494 will only be on
trunk) and applied the fix for CASSANDRA-10854 since it requires extra work on
this branch.
+1, can you just check the failing dtest
{{cqlsh_copy_tests.py:CqlshCopyTest.test_read_missing_partition_key}} from
CASSANDRA-10854?
bq. I would like to squash the dtest commits as well, let me know if you still
need to review some individual commits first.
Feel free to squash and up-merge.
bq. I'm still waiting to hear about which branches we need to apply this patch
to; plus I would like to squash the commits before up-merging.
I'd agree with [~iamaleksey] that this should go only on 3.0+, however, since
this is a follow-up/complement to CASSANDRA-9302, which is a new feature and
went into an unreleased 2.1 version, I'd advocate for this to go into 2.1 as
well, unless CASSANDRA-9302 is removed from 2.1, otherwise the *new copy
from/to* feature would ship half-complete on 2.1 what wouldn't make much sense
IMO.
was (Author: pauloricardomg):
Looks good now. Tested locally and all options look good. Dtests are also
passing. Only minor nit is to use {{os.linesep}} instead of {{'\n'}} on
{{_printmsg(msg, eol='\n')}}.
bq. It doesn't work because stdin is actually set to the file specified with
the -f option. Since this is not an issue with COPY but with the way -f is
implemented, I would prefer deferring to another ticket if this functionality
is required.
+1
bq. I've also rebased on the 2.1 branch (since CASSANDRA-9494 will only be on
trunk) and applied the fix for CASSANDRA-10854 since it requires extra work on
this branch.
+1, can you just check the failing dtest
{{cqlsh_copy_tests.py:CqlshCopyTest.test_read_missing_partition_key}} from
CASSANDRA-10854?
bq. I would like to squash the dtest commits as well, let me know if you still
need to review some individual commits first.
Feel free to squash and up-merge.
bq. I'm still waiting to hear about which branches we need to apply this patch
to; plus I would like to squash the commits before up-merging.
I'd agree with [~iamaleksey] that this should go only on 3.0+, however, since
this is a follow-up/complement to CASSANDRA-9302, which is a new feature and
went into an unreleased 2.1 version, I'd advocate for this to go into 2.1 as
well, unless CASSANDRA-9302 is removed from 2.1, otherwise the *new copy
from/to* feature would ship half-complete on 2.1 what wouldn't make much sense.
> Match cassandra-loader options in COPY FROM
> -------------------------------------------
>
> Key: CASSANDRA-9303
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9303
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Priority: Critical
> Fix For: 3.0.x, 3.x
>
>
> https://github.com/brianmhess/cassandra-loader added a bunch of options to
> handle real world requirements, we should match those.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
