[ https://issues.apache.org/jira/browse/CASSANDRA-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088892#comment-15088892 ]
Branimir Lambov commented on CASSANDRA-10887: --------------------------------------------- Pushed all branches to github to run tests: |[2.0|https://github.com/blambov/cassandra/tree/kohlisankalp/10887]|[utests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-dtest/]| |[2.1|https://github.com/blambov/cassandra/tree/kohlisankalp/10887-2.1]|[utests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-2.1-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-2.1-dtest/]| |[2.2|https://github.com/blambov/cassandra/tree/kohlisankalp/10887-2.2]|[utests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-2.2-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-2.2-dtest/]| |[3.0|https://github.com/blambov/cassandra/tree/kohlisankalp/10887-3.0]|[utests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-3.0-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/blambov/job/blambov-kohlisankalp-10887-3.0-dtest/]| 3.0 tests are quite unstable, but eventually got a clean enough run. Ready to commit. > Pending range calculator gives wrong pending ranges for moves > ------------------------------------------------------------- > > Key: CASSANDRA-10887 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10887 > Project: Cassandra > Issue Type: Bug > Components: Coordination > Reporter: Richard Low > Assignee: sankalp kohli > Priority: Critical > Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x > > Attachments: CASSANDRA-10887.diff, CASSANDRA_10887_2.2.diff, > CASSANDRA_10887_3.0.diff, CASSANDRA_10887_v2.diff, CASSANDRA_10887_v3.diff > > > My understanding is the PendingRangeCalculator is meant to calculate who > should receive extra writes during range movements. However, it adds the > wrong ranges for moves. An extreme example of this can be seen in the > following reproduction. Create a 5 node cluster (I did this on 2.0.16 and > 2.2.4) and a keyspace RF=3 and a simple table. Then start moving a node and > immediately kill -9 it. Now you see a node as down and moving in the ring. > Try a quorum write for a partition that is stored on that node - it will fail > with a timeout. Further, all CAS reads or writes fail immediately with > unavailable exception because they attempt to include the moving node twice. > This is likely to be the cause of CASSANDRA-10423. > In my example I had this ring: > 127.0.0.1 rack1 Up Normal 170.97 KB 20.00% > -9223372036854775808 > 127.0.0.2 rack1 Up Normal 124.06 KB 20.00% > -5534023222112865485 > 127.0.0.3 rack1 Down Moving 108.7 KB 40.00% > 1844674407370955160 > 127.0.0.4 rack1 Up Normal 142.58 KB 0.00% > 1844674407370955161 > 127.0.0.5 rack1 Up Normal 118.64 KB 20.00% > 5534023222112865484 > Node 3 was moving to -1844674407370955160. I added logging to print the > pending and natural endpoints. For ranges owned by node 3, node 3 appeared in > pending and natural endpoints. The blockFor is increased to 3 so we’re > effectively doing CL.ALL operations. This manifests as write timeouts and CAS > unavailables when the node is down. > The correct pending range for this scenario is node 1 is gaining the range > (-1844674407370955160, 1844674407370955160). So node 1 should be added as a > destination for writes and CAS for this range, not node 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)