[ 
https://issues.apache.org/jira/browse/CASSANDRA-11090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138007#comment-15138007
 ] 

Blake Eggleston commented on CASSANDRA-11090:
---------------------------------------------

Functionally, this is fine, but could you're checking iterator.hasNext twice. 
Could you move the flushInternal call under the original hasNext check? So it 
looks like this:

{code}
if (!iterator.hasNext())
    break;
flushInternal(iterator, store);
{code}

> Hinted Handoff loop
> -------------------
>
>                 Key: CASSANDRA-11090
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11090
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 3.0.x, 3.x
>
>
> After the hints executor finishes sending hints, another hints file is 
> created for the same host, which is then processed on the next go around. 
> This continues indefinitely. The new hint files are empty, so there shouldn't 
> be any network traffic. However, there's still unnecessary hint activity, and 
> the hint crc file isn't deleted in the 3.0 branch after hints are dispatched 
> (but is in trunk), so any hint activity will trigger ~8640 files being 
> created per day until the node is restarted. Restarting the node fixes the 
> problem, after the existing hint files are processed. 
> This can be duplicated on cassandra-3.0 to trunk with this script: 
> https://gist.github.com/bdeggleston/13fbb9e70c0c0bd277c7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to