[ 
https://issues.apache.org/jira/browse/CASSANDRA-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169740#comment-15169740
 ] 

Benjamin Lerer commented on CASSANDRA-10707:
--------------------------------------------

I have pushed a set of commits to address the different review points.

I have not changed the CQL syntax so far.

I did not rename {{CqlGroupByLimits}} as it is only used for {{GROUP BY}} 
queries and not for aggregate queries (queries with aggregates but no group 
by). I also did not rename {{GroupMaker}} as the class is really about creating 
groups, but I am fully open to discussion.

I noticed that {{{CQLLimits.forShortReadRetry()}} does not provide any limit on 
the number of rows either.



> Add support for Group By to Select statement
> --------------------------------------------
>
>                 Key: CASSANDRA-10707
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10707
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>
> Now that Cassandra support aggregate functions, it makes sense to support 
> {{GROUP BY}} on the {{SELECT}} statements.
> It should be possible to group either at the partition level or at the 
> clustering column level.
> {code}
> SELECT partitionKey, max(value) FROM myTable GROUP BY partitionKey;
> SELECT partitionKey, clustering0, clustering1, max(value) FROM myTable GROUP 
> BY partitionKey, clustering0, clustering1; 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to