[
https://issues.apache.org/jira/browse/CASSANDRA-11051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225887#comment-15225887
]
Marcus Eriksson edited comment on CASSANDRA-11051 at 4/5/16 8:40 AM:
---------------------------------------------------------------------
Wrote a unit test and noticed that we would log the "... parameter is ignored
when ..."-message even if the newly created table was OK. Reason is that we
call LZ4Compressor.create(...) for every existing table in the keyspace when we
create a new table. Changed to only log if we create a new instance and a few
small changes to make this testable. Pushed as a new commit to the repo above
Could you have a quick look [~mkjellman]?
was (Author: krummas):
Wrote a unit test and noticed that we would log the "... parameter is ignored
when ..."-message even if the newly created table was OK. Reason is that we
call LZ4Compressor.create(...) for every existing table in the keyspace when we
create a new table. Moved the logging to the constructor and a few small
changes to make this testable. Pushed as a new commit to the repo above
Could you have a quick look [~mkjellman]?
> Make LZ4 Compression Level Configurable
> ----------------------------------------
>
> Key: CASSANDRA-11051
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11051
> Project: Cassandra
> Issue Type: Improvement
> Components: Compaction
> Reporter: Michael Kjellman
> Assignee: Michael Kjellman
> Attachments: lz4_2.2.patch
>
>
> We'd like to make the LZ4 Compressor implementation configurable on a per
> column family basis. Testing has shown a ~4% reduction in file size with the
> higher compression LZ4 implementation vs the standard compressor we currently
> use instantiated by the default constructor. The attached patch adds the
> following optional parameters 'lz4_compressor_type' and
> 'lz4_high_compressor_level' to the LZ4Compressor. If none of the new optional
> parameters are specified, the Compressor will use the same defaults Cassandra
> has always had for LZ4.
> New LZ4Compressor Optional Parameters:
> * lz4_compressor_type can currently be either 'high' (uses LZ4HCCompressor)
> or 'fast' (uses LZ4Compressor)
> * lz4_high_compressor_level can be set between 1 and 17. Not specifying a
> compressor level while specifying lz4_compressor_type as 'high' will use a
> default level of 9 (as picked by the LZ4 library as the "default").
> Currently, we use the default LZ4 compressor constructor. This change would
> just expose the level (and implementation to use) to the user via the schema.
> There are many potential cases where users may find that the tradeoff in
> additional CPU and memory usage is worth the on-disk space savings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
