[
https://issues.apache.org/jira/browse/CASSANDRA-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252357#comment-15252357
]
Yuki Morishita commented on CASSANDRA-11579:
--------------------------------------------
Updated branch and tests were run.
* Renamed methods/class in {{SequentialWriterOption}}
* Move option to constant in
{{ChecksummedSequentialWriter}}/{{OnDiskIndexBuilder}}
* Changed to hold ref to {{SequentialWriterOption}} in {{SequentialWriter}}
instead of copying values.
I kept {{Optional}} for {{digestFile}} since the value can be null.
{{SSTablesIteratedTest}} was failed in testall, but in local, the test runs
fine.
bq. Regarding your comment for trickleFsync in the description, I don't see the
actual change. Can you give me a heads-up?
Right now, when {{tricleFsync}} is on, all writes using {{SequentialWriter}}
like CRC can trickle also. But writing CRC is small so you don't need to
{{trickleFsync}}. I left setting {{trickleFsync}} in new
{{SequentialWriterOption}} in those situation.
> remove DatabaseDescriptor dependency from SequentialWriter
> ----------------------------------------------------------
>
> Key: CASSANDRA-11579
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11579
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Yuki Morishita
> Assignee: Yuki Morishita
> Priority: Minor
>
> {{SequentialWriter}} and its subclass is widely used in Cassandra, mainly
> from SSTable. Removing dependency to {{DatabaseDescriptor}} improve
> reusability of this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
