[ 
https://issues.apache.org/jira/browse/CASSANDRA-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252485#comment-15252485
 ] 

Tyler Hobbs edited comment on CASSANDRA-11627 at 4/21/16 7:14 PM:
------------------------------------------------------------------

The patch is pretty straightfoward.  There were still a few uses of 
{{getNonSystemKeyspaces()}} that made sense with the current behavior, so I 
simply added a new {{getNonLocalStrategyKeyspaces()}} method and switched most 
users over to that.

Patches and pending CI tests (the trunk patch only had minor conflicts when 
merging):
||branch||testall||dtest||
|[CASSANDRA-11627-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-11627-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11627-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11627-3.0-dtest]|
|[CASSANDRA-11627-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-11627-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11627-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11627-trunk-dtest]|


was (Author: thobbs):
The patch is pretty straightfoward.  There were still a few uses of 
{{getNonSystemKeyspaces()}} that made sense with the current behavior, so I 
simply added a new {{getNonLocalStrategyKeyspaces()}} method and switched most 
users over to that.

Patches and pending CI tests (the trunk patch only had minor conflicts when 
merging):
||branch||testall||dtest||
|[CASSANDRA-11672-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-11672-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11672-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11672-3.0-dtest]|
|[CASSANDRA-11672-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-11672-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11672-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11672-trunk-dtest]|

> Streaming and other ops should filter out all LocalStrategy keyspaces, not 
> just system keyspaces
> ------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11627
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11627
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>            Priority: Minor
>             Fix For: 3.0.x, 3.x
>
>
> Streaming operations currently filter ignore system keyspaces (at least, all 
> system keyspaces that use LocalStrategy), but they technically need to ignore 
> _all_ LocalStrategy keyspaces, not just system ones.  There are also a few 
> non-streaming operations that need to do the same thing: cleanup, key range 
> sampling, and nodetool status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to