[ 
https://issues.apache.org/jira/browse/CASSANDRA-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257114#comment-15257114
 ] 

Blake Eggleston commented on CASSANDRA-11600:
---------------------------------------------

I've updated the linked branches. Changing the conditional that way would cause 
it to fail in the case that you're using CMS, but haven't set either 
MAX_HEAP_SIZE or HEAP_NEWSIZE. I did remove the nested conditional by making it 
an elif block though. Let me know if that works for you. I've also updated 
cassandra-env.ps1... although this is my first time writing powershell, and I 
don't have a windows machine to test on. All I can say for sure about that is 
that I've done my best :)

> Don't require HEAP_NEW_SIZE to be set when using G1
> ---------------------------------------------------
>
>                 Key: CASSANDRA-11600
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11600
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 3.6, 3.0.x
>
>
> Although cassandra-env.sh doesn't set -Xmn (unless set in jvm.options) when 
> using G1GC, it still requires that you set HEAP_NEW_SIZE and MAX_HEAP_SIZE 
> together, and won't start until you do. Since we ignore that setting if 
> you're using G1, we shouldn't require that the user set it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to