[ 
https://issues.apache.org/jira/browse/CASSANDRA-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258113#comment-15258113
 ] 

Philip Thompson commented on CASSANDRA-7019:
--------------------------------------------

While running a long test with 7019, I'm seeing this OOM:
{code}
ERROR [CompactionExecutor:7] 2016-04-26 07:34:46,758 CassandraDaemon.java:195 - 
Exception in thread Thread[CompactionExecutor:7,1,main]
java.lang.OutOfMemoryError: null
        at org.apache.cassandra.io.util.Memory.<init>(Memory.java:78) 
~[main/:na]
        at org.apache.cassandra.io.util.SafeMemory.<init>(SafeMemory.java:32) 
~[main/:na]
        at org.apache.cassandra.io.util.SafeMemory.copy(SafeMemory.java:72) 
~[main/:na]
        at 
org.apache.cassandra.io.util.SafeMemoryWriter.reallocate(SafeMemoryWriter.java:55)
 ~[main/:na]
        at 
org.apache.cassandra.io.util.SafeMemoryWriter.setCapacity(SafeMemoryWriter.java:68)
 ~[main/:na]
        at 
org.apache.cassandra.io.sstable.IndexSummaryBuilder.prepareToCommit(IndexSummaryBuilder.java:210)
 ~[main/:na]
        at 
org.apache.cassandra.io.sstable.format.big.BigTableWriter$IndexWriter.doPrepare(BigTableWriter.java:473)
 ~[main/:na]
        at 
org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
 ~[main/:na]
        at 
org.apache.cassandra.io.sstable.format.big.BigTableWriter$TransactionalProxy.doPrepare(BigTableWriter.java:307)
 ~[main/:na]
        at 
org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
 ~[main/:na]
        at 
org.apache.cassandra.io.sstable.format.SSTableWriter.prepareToCommit(SSTableWriter.java:275)
 ~[main/:na]
        at 
org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:367)
 ~[main/:na]
        at 
org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
 ~[main/:na]
        at 
org.apache.cassandra.db.compaction.writers.CompactionAwareWriter.doPrepare(CompactionAwareWriter.java:110)
 ~[main/:na]
        at 
org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:173)
 ~[main/:na]
        at 
org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:184)
 ~[main/:na]
        at 
org.apache.cassandra.db.compaction.writers.CompactionAwareWriter.finish(CompactionAwareWriter.java:120)
 ~[main/:na]
        at 
org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:197)
 ~[main/:na]
        at 
org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
~[main/:na]
        at 
org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:82)
 ~[main/:na]
        at 
org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
 ~[main/:na]
        at 
org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:265)
 ~[main/:na]
        at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
~[na:1.8.0_40]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
~[na:1.8.0_40]
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
~[na:1.8.0_40]
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[na:1.8.0_40]
        at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
{code}

This is with {{provide_overlapping_tombstones: NONE}}, however. I am also 
running my test on trunk, and have not seen the issue there yet, nor on any of 
my other runs. 
https://gist.github.com/ptnapoleon/ce59cc5a2a42ecfd3d27657f311e4615

I've attached the debug.log of the node, as 7019-debug.log

> Improve tombstone compactions
> -----------------------------
>
>                 Key: CASSANDRA-7019
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7019
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Marcus Eriksson
>            Assignee: Branimir Lambov
>              Labels: compaction
>             Fix For: 3.x
>
>         Attachments: 7019-debug.log
>
>
> When there are no other compactions to do, we trigger a single-sstable 
> compaction if there is more than X% droppable tombstones in the sstable.
> In this ticket we should try to include overlapping sstables in those 
> compactions to be able to actually drop the tombstones. Might only be doable 
> with LCS (with STCS we would probably end up including all sstables)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to