[ https://issues.apache.org/jira/browse/CASSANDRA-11719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310045#comment-15310045 ]
Robert Stupp commented on CASSANDRA-11719: ------------------------------------------ Mostly looks good. A few things - after that it's good to go. * Start counting the bind variables with 0 (not with 1) (at {{builder.put("bound_var_" +...}}) * Fix the comment above that {{Here we prefix boundName with a prefix to }} to {{Here we prefix boundName with the index to }} * Since {{boundValue}} can become quite big, I'd prefer to limit it to 1000 chars and add {{...}} if it exceeds that length. * Can you add a map and a tuple column to the table in the utest with a couple of values? You can also use that to test the previous point. > Add bind variables to trace > --------------------------- > > Key: CASSANDRA-11719 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11719 > Project: Cassandra > Issue Type: Improvement > Reporter: Robert Stupp > Assignee: Mahdi Mohammadi > Priority: Minor > Labels: lhf > Fix For: 3.x > > Attachments: 11719-trunk.patch > > > {{org.apache.cassandra.transport.messages.ExecuteMessage#execute}} mentions a > _TODO_ saying "we don't have [typed] access to CQL bind variables here". > In fact, we now have access typed access to CQL bind variables there. So, it > is now possible to show the bind variables in the trace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)