[ https://issues.apache.org/jira/browse/CASSANDRA-11854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314457#comment-15314457 ]
Paulo Motta commented on CASSANDRA-11854: ----------------------------------------- Attaching simple patch that adds a listener to the stream session and remove it from the incoming connections map when the session is finished. ||2.1||2.2||3.0||3.7||trunk|| |[branch|https://github.com/apache/cassandra/compare/cassandra-2.1...pauloricardomg:2.1-11854]|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:2.2-11854]|[branch|https://github.com/apache/cassandra/compare/cassandra-3.0...pauloricardomg:3.0-11854]|[branch|https://github.com/apache/cassandra/compare/cassandra-3.7...pauloricardomg:3.7-11854]|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-11854]| |[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.1-11854-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.2-11854-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-11854-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.7-11854-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-11854-testall/lastCompletedBuild/testReport/]| |[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.1-11854-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-2.2-11854-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.0-11854-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-3.7-11854-dtest/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-11854-dtest/lastCompletedBuild/testReport/]| Mind reviewing [~yukim]? Tests are still running, will update when they're finished. commit info: merge conflict from 2.1 to 2.2, changed 3.0 patch to use lambda. > Remove finished streaming connections from MessagingService > ----------------------------------------------------------- > > Key: CASSANDRA-11854 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11854 > Project: Cassandra > Issue Type: Bug > Reporter: Paulo Motta > Assignee: Paulo Motta > Attachments: oom.png > > > When a new {{IncomingStreamingConnection}} is created, [we register it in the > connections > map|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/MessagingService.java#L1109] > of {{MessagingService}}, but we [only remove it if there is an > exception|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/IncomingStreamingConnection.java#L83] > while attaching the socket to the stream session. > On nodes with SSL and large number of vnodes, after many repair sessions > these old connections can accumulate and cause OOM (heap dump attached). > The connection should be removed from the connections map after if it's > finished in order to be garbage collected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)