[ https://issues.apache.org/jira/browse/CASSANDRA-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314647#comment-15314647 ]
Alex Petrov commented on CASSANDRA-11937: ----------------------------------------- Just read my message again, it's a bit wrong. The patch is [merged|https://github.com/netty/netty/pull/5333] to both 4.0 and 4.1. We need to wait until the next 4.0 release is out, which allows us to upgrade without trouble, and remove the buffer trimming from [here|https://github.com/apache/cassandra/commit/eb5a59a311a14cc0a3c37a13d10abc8c5a0f6d1b#diff-6aa10752b68c93ed354d642f9bdbe814R92] (instead of trimming buffers we'll be able to just throw them away / not recycle). > Clean up buffer trimming large buffers in DataOutputBuffer after the Netty > upgrade > ---------------------------------------------------------------------------------- > > Key: CASSANDRA-11937 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11937 > Project: Cassandra > Issue Type: Improvement > Reporter: Alex Petrov > Labels: lhf, netty, reminder > > In [https://issues.apache.org/jira/browse/CASSANDRA-11838|11838], we're > trimming the large buffers in {{DataOutputBuffer}}. The patch is already > submitted and merged in [Netty > 4.1|https://github.com/netty/netty/commit/bbed330468b5b82c9e4defa59012d0fcdb70f1aa], > we only need to make sure that we throw large buffers away1 alltogether > instead of trimming them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)