[
https://issues.apache.org/jira/browse/CASSANDRA-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331239#comment-15331239
]
Joel Knighton commented on CASSANDRA-11696:
-------------------------------------------
Overall, the patches look good to me and the logic of the fix seems sound. One
exceedingly minor nit - on the 3.0 and up patches, the comment beginning with
"this means the parent repair session" in {{doValidationCompaction}} has had
its ending removed. One small question - is there a reason {{marked}} needs to
be a map in {{ParentRepairSession}}? It seems to only ever be a map from UUID
to {{true}}, in which case we might as well use a set.
Tests are less clean - the 3.7-testall failed to run entirely. Otherwise, the
testall runs look good. The 2.1 dtests have failures in incremental_repair_test
- these could be because your dtest branch appears to be lacking your fix from
[CASSANDRA-11436]. The 3.0 run has a lot of failures in repair_tests that look
linked to a mismatch between CCM and your dtest branch. This has been fixed in
latest dtest, so you should rebase.
If you don't have time to mess with the test stuff [~krummas], let me know and
I can rebase the dtest branch and rerun the sets I need before I'm comfortable
+1ing. Let me know.
> Incremental repairs can mark too many ranges as repaired
> --------------------------------------------------------
>
> Key: CASSANDRA-11696
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11696
> Project: Cassandra
> Issue Type: Bug
> Reporter: Joel Knighton
> Assignee: Marcus Eriksson
> Priority: Critical
> Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
>
> Incremental repairs are tracked using a parent session - a subordinate repair
> session is created for each range in the repair. When a node participating in
> the repair receives a validation request, it will reference the sstables in
> the parent repair session. When all subordinate sessions conclude, each node
> anticompacts SSTables based on the parent repair session for the whole range
> of the repair, but these referenced SSTables may have only been present for
> the validation of some subset of the ranges because the SSTables were created
> concurrent with the parent repair session.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
