[
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403229#comment-15403229
]
Stefania commented on CASSANDRA-12348:
--------------------------------------
Thanks for the review. I've added a comment to {{validateCFS}} and then
committed the fix to 3.9 as e89028d34c699916b8c94b52f4cb3e086d8b81c1 and merged
into trunk.
I did not add a {{LifecycleTransaction.waitForDeletions()}} after
{{CompactionManager.instance.submitMaximal}} because we would have also had to
wait on the future first. I think a better approach would be not to submit the
maximal compaction task but to just check that there exists at least one. I
think this was the intention of the test.
We can reopen this ticket or create a new one if we want to change this test
further.
> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -----------------------------------------------------------------
>
> Key: CASSANDRA-12348
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
> Reporter: Joel Knighton
> Assignee: Stefania
> Fix For: 3.9
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a
> rewrite.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
