[ https://issues.apache.org/jira/browse/CASSANDRA-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404046#comment-15404046 ]
Aleksey Yeschenko commented on CASSANDRA-12236: ----------------------------------------------- Alright. Two issues: 1. {{SimpleBuilders#AbstractBuilder#nowInSec() method has an invalid argument ({{int ttl}} instead of {{int nowInSec}}), making the method a no-op 2. SimpleBuilders#RowBuilder#add() in the {{SET}} case in the for loop is using the incorrect variable in {{toByteBuffer()}} call ({{value}} instead of {{elt}}) One nit: the change in MigrationManager is contaminating git blame, no need for it One subjective preference: not a fan of {{addNoOverride()}} name. Maybe just replace with {{append()}}? Otherwise LGTM conditional on tests passing. > RTE from new CDC column breaks in flight queries. > ------------------------------------------------- > > Key: CASSANDRA-12236 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12236 > Project: Cassandra > Issue Type: Bug > Reporter: Jeremiah Jordan > Assignee: Sylvain Lebresne > Fix For: 3.x > > Attachments: 12236.txt > > > This RTE is not harmless. It will cause the internode connection to break > which will cause all in flight requests between these nodes to die/timeout. > {noformat} > - Due to changes in schema migration handling and the storage format > after 3.0, you will > see error messages such as: > "java.lang.RuntimeException: Unknown column cdc during > deserialization" > in your system logs on a mixed-version cluster during upgrades. This > error message > is harmless and due to the 3.8 nodes having cdc added to their schema > tables while > the <3.8 nodes do not. This message should cease once all nodes are > upgraded to 3.8. > As always, refrain from schema changes during cluster upgrades. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)