[ 
https://issues.apache.org/jira/browse/CASSANDRA-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409070#comment-15409070
 ] 

Stefania commented on CASSANDRA-12379:
--------------------------------------

Thanks. Committed to 3.8 as 18c357b8634fd5e846d96b674aa7d55071f29f9f and merged 
upwards with -s ours. 

I've launched the [3.8 
tests|http://cassci.datastax.com/view/cassandra-3.9/job/cassandra-3.8_cqlsh_tests/7/]
 and will verify the result later.

There's a new 
[failure|http://cassci.datastax.com/view/cassandra-3.9/job/cassandra-3.9_cqlsh_tests/lastCompletedBuild/cython=yes,label=ctool-lab/testReport/cqlshlib.test.test_cqlsh_output/TestCqlshOutput/test_describe_columnfamily_output/]
 in 3.9 and it will appear on trunk as well. This indeed is caused by #12236 
and the solution is to edit the 3.9 and trunk cqlsh jobs to set 
{{cdc_enabled=true}} in cassandra.yaml, cc [~philipthompson]. It does not apply 
to the 3.8 branch because the CDC change relative to this failure was not added 
to the cqlshlib tests for 3.8.


> CQLSH completion test broken by #12236
> --------------------------------------
>
>                 Key: CASSANDRA-12379
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12379
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Stefania
>
> The commit of CASSANDRA-12236 appears to have broken [cqlsh completion 
> tests|http://cassci.datastax.com/job/cassandra-3.8_cqlsh_tests/6/cython=yes,label=ctool-lab/testReport/junit/cqlshlib.test.test_cqlsh_completion/TestCqlshCompletion/test_complete_in_create_columnfamily/].
>  For the error message I suspect this may have to do with something like the 
> test comparing the completion output to what DESCRIBE shows and the later now 
> doesn't include the {{cdc}} option by default.
> Anyway, I'm not really familiar with cqlsh completion nor it's test so I'm 
> not sure what's the best option. I don't think we want to remove {{cdc}} from 
> completion so I suspect we want to either special case the test somehow (no 
> clue how to do that), or make the test run with cdc enabled so it doesn't 
> complain (which I think mostly apply a change to the CI environment since it 
> seems the tests themselves don't spin up the cluster).
> Anyway, pushing that fix to someone else as I'm not competent here and I 
> have't even be able to run those cqlsh test so far (getting stuck at the test 
> telling me that "No appropriate python interpreter found", even though I 
> totally have an appropriate interpreter and cqlsh works perfectly if I 
> execute it directly). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to