[ 
https://issues.apache.org/jira/browse/CASSANDRA-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413168#comment-15413168
 ] 

Alex Petrov commented on CASSANDRA-11990:
-----------------------------------------

bq. The branch you have in the previous comment still have all of the change 
from dropping/rebuilding of the indexes.

My bad. I've included them just to make review and running tests simpler for 
you. I was going to rebase once the other tickets are fixed/merged.

bq. I'm not comfortable committing code just because it's hard to get out from 
the patch. 

Sure, neither am I. It's not hard to get it out from the patch, I wanted to 
avoid removing it today and bring it back it in in a follow-up patch in a week. 

Anyways, I agree with the fact that the smaller scope is better, just had to 
make sure we're on the same page and discuss alternatives.
I'm going to work on this patch over this week again.

> Address rows rather than partitions in SASI
> -------------------------------------------
>
>                 Key: CASSANDRA-11990
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11990
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL, sasi
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>         Attachments: perf.pdf, size_comparison.png
>
>
> Currently, the lookup in SASI index would return the key position of the 
> partition. After the partition lookup, the rows are iterated and the 
> operators are applied in order to filter out ones that do not match.
> bq. TokenTree which accepts variable size keys (such would enable different 
> partitioners, collections support, primary key indexing etc.), 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to