[ 
https://issues.apache.org/jira/browse/CASSANDRA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414822#comment-15414822
 ] 

Branimir Lambov commented on CASSANDRA-12283:
---------------------------------------------

The wait condition is incorrect, this includes {{now}} twice which I believe 
makes it time out when it should fail.

On the {{yield}} question, this call is a sensible way of spinning when you do 
not want to be wasting resources (the behaviour described in your link is 
specifically chosen to make sense for this use pattern). The alternative is to 
sleep (in this case {{sleep(50)}} or so will be good enough), but not to remove 
it as this ties up the CPU core and makes the task you want to wait for 
complete slower.

> CommitLogSegmentManagerTest.testCompressedCommitLogBackpressure is flaky
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12283
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12283
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Joshua McKenzie
>            Assignee: Benjamin Lerer
>            Priority: Minor
>              Labels: unittest
>
> Failed 3 of the last 38 runs.
> [Failure|http://cassci.datastax.com/job/cassandra-3.9_testall/lastCompletedBuild/testReport/org.apache.cassandra.db.commitlog/CommitLogSegmentManagerTest/testCompressedCommitLogBackpressure/]
> Details:
> Error Message
> Timeout occurred. Please note the time in the report does not reflect the 
> time until the timeout.
> Stacktrace
> junit.framework.AssertionFailedError: Timeout occurred. Please note the time 
> in the report does not reflect the time until the timeout.
>       at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to