[ 
https://issues.apache.org/jira/browse/CASSANDRA-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432083#comment-15432083
 ] 

Stefania commented on CASSANDRA-12490:
--------------------------------------

Thanks for the updated patch, LGTM. 

I've created a branch with your patch and some nits. I've also started the CI 
jobs for trunk but they are still in a queue at the moment:

|[patch|https://github.com/stef1927/cassandra/commits/12490]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12490-testall/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12490-dtest/]|

If you are happy with the nits, and the CI results are good, I'll squash and 
commit. 

Do you think we should add a sample stress profile, I've used [this 
one|^cqlstress-seq-example.yaml] for testing, do you have a more realistic 
sample or is this one good enough? 

> Add sequence distribution type to cassandra stress
> --------------------------------------------------
>
>                 Key: CASSANDRA-12490
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12490
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Ben Slater
>            Assignee: Ben Slater
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: 12490-trunk.patch, cqlstress-seq-example.yaml
>
>
> When using the write command, cassandra stress sequentially generates seeds. 
> This ensures generated values don't overlap (unless the sequence wraps) 
> providing more predictable number of inserted records (and generating a base 
> set of data without wasted writes).
> When using a yaml stress spec there is no sequenced distribution available. 
> It think it would be useful to have this for doing initial load of data for 
> testing 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to