[ 
https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masataka Yamaguchi updated CASSANDRA-12486:
-------------------------------------------
    Attachment: compactionhistory_result-v2.yaml
                compactionhistory_result-v2.txt
                compactionhistory_result-v2.json
                CASSANDRA-12486-v2-git-format-patch.patch

First, printing out compactionhistory as a list sorted by compacted_at sounds 
better for me than an associative array whose key is each compaction’s id, so I 
rewrote the patch so as to print it as a list sorted by compacted_at. 
Second, I also think that we should print it in the same way as default 
printer. So I changed the way of printing compacted_at in the patch.
I attached the new patch and new output files, so please review it when you 
have time. Please note that the new patch was generated with git format-patch, 
while the previous patch was generated by patch command.
Thank you.


> Structure for compactionhistory output (JSON, YAML)
> ---------------------------------------------------
>
>                 Key: CASSANDRA-12486
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12486
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Masataka Yamaguchi
>            Assignee: Masataka Yamaguchi
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: CASSANDRA-12486-trunk.patch, 
> CASSANDRA-12486-v2-git-format-patch.patch, compactionhistory_result-v2.json, 
> compactionhistory_result-v2.txt, compactionhistory_result-v2.yaml, 
> compactionhistory_result.json, compactionhistory_result.txt, 
> compactionhistory_result.yaml
>
>
> As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool 
> compactionhistory should also support useful output formats such as JSON or 
> YAML, so we implemented it. 
> Please review the attached patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to