[ https://issues.apache.org/jira/browse/CASSANDRA-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455359#comment-15455359 ]
Sylvain Lebresne commented on CASSANDRA-12423: ---------------------------------------------- The changes looks good, but the method feels a bit harder to read than it really should so I took the liberty to reorganize it a bit below (it's equivalent logic-wise though, hopefully at least). I'm nitpicking the shit out of this though so let me know if you think that's more readable or not really and we'll just go with whatever you prefer. | [12423-3.0|https://github.com/pcmanus/cassandra/commits/12423-3.0] | [utests|http://cassci.datastax.com/job/pcmanus-12423-3.0-testall] | [dtests|http://cassci.datastax.com/job/pcmanus-12423-3.0-dtest] | > Cells missing from compact storage table after upgrading from 2.1.9 to 3.7 > -------------------------------------------------------------------------- > > Key: CASSANDRA-12423 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12423 > Project: Cassandra > Issue Type: Bug > Reporter: Tomasz Grabiec > Assignee: Stefania > Attachments: 12423.tar.gz > > > Schema: > {code} > create table ks1.test ( id int, c1 text, c2 text, v int, primary key (id, c1, > c2)) with compact storage and compression = {'sstable_compression': ''}; > {code} > sstable2json before upgrading: > {code} > [ > {"key": "1", > "cells": [["","0",1470761440040513], > ["a","asd",2470761440040513,"t",1470764842], > ["asd:","0",1470761451368658], > ["asd:asd","0",1470761449416613]]} > ] > {code} > Query result with 2.1.9: > {code} > cqlsh> select * from ks1.test; > id | c1 | c2 | v > ----+-----+------+--- > 1 | | null | 0 > 1 | asd | | 0 > 1 | asd | asd | 0 > (3 rows) > {code} > Query result with 3.7: > {code} > cqlsh> select * from ks1.test; > id | 6331 | 6332 | v > ----+------+------+--- > 1 | | null | 0 > (1 rows) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)