[
https://issues.apache.org/jira/browse/CASSANDRA-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15521876#comment-15521876
]
Stefania edited comment on CASSANDRA-12571 at 9/26/16 3:01 AM:
---------------------------------------------------------------
Thanks for your input [~Nate75Sanders].
I've checked our [own
documentation|http://cassandra.apache.org/doc/latest/tools/cqlsh.html?command-line-options#command-line-options]
and it is already correct. As for the Datastax
[documentation|https://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlshUsingCqlshrc.html#cqlshUsingCqlshrc__request-timeout],
it seems that too must have been updated in the last few days, although it
mentions {{\--timeout}} just above, rather than {{\--connect-timeout}}; cc
[~lor...@datastax.com]: it's {{\[connection\] timeout}} in .cqlshrc but
{{\--connect-timeout}} as a command line argument.
As for calling out the old behavior, not only is none no longer supported, but
also {{client-timeout}} was renamed to {{request-timeout}}. However,
{{client-timeout}} was never documented by CASSANDRA-7516, as it was intended
only for testing I believe.
So I'm not totally convinced we should pollute our in tree documentation with
this information, given that it is version based, if anything this information
should have gone into NEWS.txt when 10686 was committed.
In my opinion, if people were able to work out the existence of an undocumented
cqlsh option, they should also work out the change in behavior without too many
problems. However, if you want to produce a documentation patch, either for
NEWS.txt or the in-tree documentation itself, I can review it and commit it.
I am closing this ticket, reopen and reassign if you want to update the
documentation with the old undocumented option.
was (Author: stefania):
Thanks for your input [~Nate75Sanders].
I've checked our [own
documentation|http://cassandra.apache.org/doc/latest/tools/cqlsh.html?command-line-options#command-line-options]
and it is already correct. As for the Datastax
[documentation|https://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlshUsingCqlshrc.html#cqlshUsingCqlshrc__request-timeout],
it seems that too must have been updated in the last few days, although it
mentions {{--timeout}} just above, rather than {{-connect-timeout}}; cc
[~lor...@datastax.com]: it's {{\[connection\] timeout}} in .cqlshrc but
{{--connect-timeout}} as a command line argument.
As for calling out the old behavior, it's not just that none is no longer
supported, but also that {{client-timeout}} was renamed to {{request-timeout}}.
However, {{client-timeout}} was never documented by CASSANDRA-7516, as it was
intended only for testing.
So I'm not totally convinced we should pollute the documentation with this
information, if anything it should have gone into NEWS.txt. Besides, if people
were able to work out the existence of an undocumented cqlsh option, they
should also work out the change in behavior. However, if you want to produce a
documentation patch, either for NEWS.txt or the in-tree documentation itself, I
can commit it.
For now I am closing this ticket.
> cqlsh lost the ability to have a request wait indefinitely
> ----------------------------------------------------------
>
> Key: CASSANDRA-12571
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12571
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 3.7
> Reporter: Nate Sanders
> Assignee: Stefania
> Priority: Minor
> Labels: cqlsh, doc-impacting, lhf
>
> In commit c7f0032912798b5e53b64d8391e3e3d7e4121165, when client_timeout
> became request_timeout, the logic was changed so that you can no longer use a
> timeout of None, despite the docs saying that you can:
> https://docs.datastax.com/en/cql/3.3/cql/cql_reference/cqlshUsingCqlshrc.html#cqlshUsingCqlshrc__request-timeout
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
